From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Noah Misch <noah(at)leadboat(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: split builtins.h to quote.h |
Date: | 2014-10-11 21:43:46 |
Message-ID: | 20141011214346.GG18020@awork2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2014-10-11 17:19:27 -0400, Noah Misch wrote:
> On Sat, Oct 11, 2014 at 10:44:39AM -0300, Alvaro Herrera wrote:
> > Started a new thread to raise awareness.
>
> > Ref: this comes from
> > http://www.postgresql.org/message-id/CAB7nPqR1iVd5r_QN_ngmkBOLQmAGBOsJ4WNPo8eybNn6WE_Kdw@mail.gmail.com
>
> Thanks. You can assume I'm -1 on every header split proposal not driving a
> substantial compile duration improvement:
I don't know. Isn't it, from a aesthetic POV, wrong to have all that
stuff in builtins.h? The stuff split of really doesn't seem to belong
there?
I personally wouldn't object plaing a #include for the splitof file into
builtin.h to address backward compat concerns. Would imo still be an
improvement.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Fabrízio de Royes Mello | 2014-10-11 21:46:19 | Re: pg_dump refactor patch to remove global variables |
Previous Message | Andres Freund | 2014-10-11 21:41:47 | Re: No toast table for pg_shseclabel but for pg_seclabel |