From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, furuyao(at)pm(dot)nttdata(dot)co(dot)jp, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_receivexlog and replication slots |
Date: | 2014-10-04 15:11:46 |
Message-ID: | 20141004151146.GD32263@awork2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2014-10-04 14:25:27 +0900, Michael Paquier wrote:
> On Sat, Oct 4, 2014 at 9:24 AM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
> wrote:
>
> >
> >
> > On Sat, Oct 4, 2014 at 6:48 AM, Andres Freund <andres(at)2ndquadrant(dot)com>
> > wrote:
> >
> >> On 2014-10-03 14:02:08 -0400, Robert Haas wrote:
> >> > On Fri, Oct 3, 2014 at 7:57 AM, Andres Freund <andres(at)2ndquadrant(dot)com>
> >> wrote:
> >> > > I do wonder whether --create/--drop aren't somewhat wierd for
> >> > > pg_receivexlog. It's not that clear what it means. It'd be ugly, but
> >> we
> >> > > could rename them --create-slot/drop-slot.
> >> >
> >> > +1 on doing it, -1 on it being ugly.
> >>
> >> The reason I'm calling it uglyu is that it's different from
> >> pg_recvlogical. We could change it there, too? A bit late, but probably
> >> better than having a discrepancy forever
> >>
> > I'm on board to make things as consistent as possible between both
> > utilities, the only reason why --create/--drop are used in my patch is for
> > the sake of consistency btw. 9.4 ship has not sailed yet, and IMO it is
> > important from the user prospective if options are a maximum consistent
> > between pg_receivexlog and pg_recvlogical. That would be even better if
> > change is done before 9.4beta3 shows up, and I doubt that there are many
> > users using the --create/--drop options already.
> >
> And as I am on it, attached is a patch that can be applied to master and
> REL9_4_STABLE to rename the --create and --drop to --create-slot and
> --drop-slot.
Misses logicaldecoding.sgml... I'll fix that up, once there's agreement
whether we should continue accept the old form. No need to send a new
version.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2014-10-04 15:12:52 | Re: Fixed xloginsert_locks for 9.4 |
Previous Message | Andres Freund | 2014-10-04 15:09:56 | Re: pg_receivexlog and replication slots |