Re: Fixed xloginsert_locks for 9.4

On Fri, Oct 3, 2014 at 08:04:08PM -0400, Bruce Momjian wrote:
> On Sat, Oct 4, 2014 at 01:57:01AM +0200, Andres Freund wrote:
> > On 2014-10-03 19:54:36 -0400, Tom Lane wrote:
> > > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > > Agreeed. Also, reality check --- we can't change postgresql.conf easily
> > > > without an initdb, and I think our last 9.4 initdb is going to be
> > > > 9.4beta3, which is going to be packaged on Monday.
> > >
> > > Good point: independently of all else, it's a bit late to be adding new
> > > features to 9.4.
> >
> > This is getting absurd. The feature was there three days ago.
>
> My point is we have to have in there/decide by Monday or it isn't going
> to be in 9.4. I am unclear how we can resolve all the concerns about
> its addition in that short of a time.

Actually, another issue is that we were only able to remove
xloginsert_locks this week because we are forcing an initdb for
9.4beta3. If we had not, I am not sure how we would have removed this
undocumented setting, except to tell beta users to remove it from their
postgresql.conf file after we removed it from the server. This seems
sloppy --- we should have addressed this (documented it or removed it)
before beta1.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +