| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "Syed, Rahila" <Rahila(dot)Syed(at)nttdata(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Rahila Syed <rahilasyed(dot)90(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [REVIEW] Re: Compression of full-page-writes |
| Date: | 2014-09-29 15:29:11 |
| Message-ID: | 20140929152911.GM16581@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-09-29 18:27:01 +0300, Heikki Linnakangas wrote:
> On 09/29/2014 06:02 PM, Robert Haas wrote:
> >On Mon, Sep 29, 2014 at 8:36 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> >>1) I don't think it's a good idea to put the full page write compression
> >> into struct XLogRecord.
> >
> >Why not, and where should that be put?
>
> It should be a flag in BkpBlock.
Doesn't work with the current approach (which I don't really like
much). The backup blocks are all compressed together. *Including* all
the struct BkpBlocks. Then the field in struct XLogRecord is used to
decide whether to decompress the whole thing or to take it verbatim.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2014-09-29 15:30:26 | Re: KNN-GiST with recheck |
| Previous Message | Merlin Moncure | 2014-09-29 15:28:20 | Re: json (b) and null fields |