Re: make pg_controldata accept "-D dirname"

From: Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: make pg_controldata accept "-D dirname"
Date: 2014-09-24 13:49:20
Message-ID: 20140924134920.GA21547@toroid.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At 2014-09-24 09:25:12 -0400, tgl(at)sss(dot)pgh(dot)pa(dot)us wrote:
>
> What's so hard about [ -D ] before the datadir argument?

I'm sorry to have given you the impression that I objected to it because
it was hard. Since I proposed the same thing a few lines after what you
quoted, I guess I have to agree it's not hard.

I think it's pointless, because if you're going to look at the usage
message to begin with, why not do what it already says? But I don't
care enough to argue about it any further.

Patches attached.

-- Abhijit

P.S. Trivia: I can't find any other options in Postgres where the
argument is mandatory but the option is optional.

Attachment Content-Type Size
0001-Make-pg_controldata-ignore-a-D-before-DataDir.patch text/x-diff 1.2 KB
0002-Make-pg_resetxlog-also-accept-D-datadir.patch text/x-diff 1.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-09-24 13:54:27 Re: make pg_controldata accept "-D dirname"
Previous Message Heikki Linnakangas 2014-09-24 13:41:14 Re: delta relations in AFTER triggers