From: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com> |
---|---|
To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: make pg_controldata accept "-D dirname" |
Date: | 2014-09-24 13:16:06 |
Message-ID: | 20140924131606.GA21184@toroid.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
At 2014-09-24 16:02:29 +0300, hlinnakangas(at)vmware(dot)com wrote:
>
> Thanks. Please update the docs and usage(), too.
I'm sorry, but I don't think it would be an improvement to make the docs
explain that it's valid to use either "-D datadir" or specify it without
an option. If both commands were changed to *require* "-D datadir", that
would be worth documenting. But of course I didn't want to change any
behaviour for people who have a better memory than I do.
I think it's all right as a quick hack to remove an inconsistency that
has clearly annoyed many people, but not much more.
Would you be OK with my just sticking a "[-D]" before DATADIR in the
usage() message for both programs, with no further explanation? (But
to be honest, I don't think even that is necessary or desirable.)
-- Abhijit
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2014-09-24 13:18:35 | Re: missing isinf declaration on solaris |
Previous Message | Oskari Saarenmaa | 2014-09-24 13:11:50 | Re: missing isinf declaration on solaris |