Re: better atomics - v0.6

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Geoghegan <pg(at)heroku(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Ants Aasma <ants(at)cybertec(dot)at>
Subject: Re: better atomics - v0.6
Date: 2014-09-22 21:01:07
Message-ID: 20140922210106.GC2521@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I've finally managed to incorporate (all the?) feedback I got for
0.5. Imo the current version looks pretty good.

Most notable changes:
* Lots of comment improvements
* code moved out of storage/ into port/
* separated the s_lock.h changes into its own commit
* merged i386/amd64 into one file
* fixed lots of the little details Amit noticed
* fixed lots of XXX/FIXMEs
* rebased to today's master
* tested various gcc/msvc versions
* extended the regression tests
* ...

The patches:
0001: The actual atomics API
0002: Implement s_lock.h support ontop the atomics API. Existing
implementations continue to be used unless
FORCE_ATOMICS_BASED_SPINLOCKS is defined
0003-0005: Not proposed for review here. Just included because code
actually using the atomics make testing them easier.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
0001-Add-a-basic-atomic-ops-API-abstracting-away-platform.patch text/x-patch 108.3 KB
0002-Add-implementation-of-spinlocks-using-the-atomics.h-.patch text/x-patch 3.6 KB
0003-XXX-Hack-ShmemAlloc-to-align-all-allocations-to-cach.patch text/x-patch 1.4 KB
0004-Convert-the-PGPROC-lwWaitLink-list-into-a-dlist-inst.patch text/x-patch 10.9 KB
0005-Wait-free-LW_SHARED-lwlock-acquiration.patch text/x-patch 37.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2014-09-22 21:22:10 Re: A mechanism securing web applications in DBMS
Previous Message Merlin Moncure 2014-09-22 20:58:47 Re: Anonymous code block with parameters