| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Dilip kumar <dilip(dot)kumar(at)huawei(dot)com>, pgsql-hackers(at)postgresql(dot)org, furuyao(at)pm(dot)nttdata(dot)co(dot)jp |
| Subject: | Re: pg_xlogdump --stats |
| Date: | 2014-09-19 22:34:08 |
| Message-ID: | 20140919223408.GT4701@eldon.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund wrote:
> Hi,
>
> On 2014-09-19 15:39:37 +0530, Abhijit Menon-Sen wrote:
> > I've attached the revised patch, split up differently:
> >
> > 1. Introduce rm_identify, change rm_desc, glue the two together in
> > xlog.c
> > 2. Introduce pg_xlogdump --stats[=record].
>
> I've pushed these after some fixing up.
Hm, did you keep the static thingy you mentioned upthread (append_init
which is duped unless I read wrong)? There's quite some angst due to
pg_dump's fmtId() -- I don't think we should be introducing more such
things ...
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-09-19 22:36:35 | Re: pg_xlogdump --stats |
| Previous Message | Brightwell, Adam | 2014-09-19 22:03:38 | Re: RLS Design |