Re: pgsql: Add new psql help topics, accessible to both --help and \?.

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add new psql help topics, accessible to both --help and \?.
Date: 2014-09-10 01:04:16
Message-ID: 20140910010416.GI24649@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2014-09-09 22:12:35 +0000, Andres Freund wrote:
> Add new psql help topics, accessible to both --help and \?.
>
> Add --help=<topic> for the commandline, and \? <topic> as a backslash
> command, to show more help than the invocations without parameters
> do. "commands", "variables" and "options" currently exist as help
> topics describing, respectively, backslash commands, psql variables,
> and commandline switches. Without parameters the help commands show
> their previous topic.
>
> Some further wordsmithing or extending of the added help content might
> be needed; but there seems little benefit delaying the overall feature
> further.
>
> Author: Pavel Stehule, editorialized by many
>
> Reviewed-By: Andres Freund, Petr Jelinek, Fujii Masao, MauMau, Abhijit
> Menon-Sen and Erik Rijkers.
>
> Discussion: CAFj8pRDVGuC-nXBfe2CK8vpyzd2Dsr9GVpbrATAnZO=2YQ0s2Q(at)mail(dot)gmail(dot)com,
> CAFj8pRA54AbTv2RXDTRxiAd8hy8wxmoVLqhJDRCwEnhdd7OUkw(at)mail(dot)gmail(dot)com

Hm. This fails on windows right now because the getopt_long() fallback
implementation doesn't implement optional_argument. Unless people think
this can be broken for a day or somebody has a better solution, I'll
revert tomorrow morning.
The best plan after that seems to be to add optional_argument support to
getopt_long.c - looks easy enough. Do we need a configure test for
optional_argument? I don't think so, but I could see somebody arguing
the other way round.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Pavel Stehule 2014-09-10 09:03:14 Re: pgsql: Add new psql help topics, accessible to both --help and \?.
Previous Message Andres Freund 2014-09-10 00:45:02 pgsql: Fix typo in 07c8651dd91d5 causing WIN32_ONLY_COMPILER builds to