From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Stephen Frost <sfrost(at)snowman(dot)net> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: ALTER TABLESPACE MOVE command tag tweak |
Date: | 2014-09-08 20:42:14 |
Message-ID: | 20140908204213.GB31032@eldon.alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Stephen Frost wrote:
> Alvaro,
>
> * Alvaro Herrera (alvherre(at)2ndquadrant(dot)com) wrote:
> > ALTER TABLE ALL IN TABLESPACE xyz
> > which AFAICS should work since ALL is already a reserved keyword.
>
> Pushed to master and REL9_4_STABLE.
Thanks. One more tweak --- the whole reason for fiddling with this is
to ensure that event triggers support this operation. Therefore this
node should be handled by ProcessUtilitySlow, not
standard_ProcessUtility, as in the attached patch.
(I checked the documentation for necessary updates; turns out that the
table in the event triggers chapter says that ddl_command_end etc
support the command "ALTER TABLE", and since this is the tag returned by
the new ALTER TABLE ALL IN TABLESPACE command, there is no update
needed. In fact, one can argue that the table is wrong currently
because it doesn't say that ALTER TABLE ALL IN TABLESPACE is not
supported.)
I propose this for 9.4 too.
> Apologies on it taking so long-
> things have a bit "interesting" for me over the past month or two. :)
I bet they have! Have fun,
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachment | Content-Type | Size |
---|---|---|
all_tablespace.patch | text/x-diff | 837 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2014-09-08 20:44:29 | Re: bad estimation together with large work_mem generates terrible slow hash joins |
Previous Message | Robert Haas | 2014-09-08 18:46:21 | Re: Scaling shared buffer eviction |