From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, TAKATSUKA Haruka <harukat(at)sraoss(dot)co(dot)jp>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org> |
Subject: | Re: BUG #11335: an invalid prepare statement causes crash at log_statement = 'mod' or 'ddl'. |
Date: | 2014-09-06 20:34:10 |
Message-ID: | 20140906203410.GK26947@awork2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On 2014-09-06 16:25:28 -0400, Tom Lane wrote:
> Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
> > On Thu, Sep 4, 2014 at 3:55 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> >> Thanks for reporting the bug! This segmentation fault could reproduce
> >> even on my machine. Barring any objection, I will apply the change that
> >> you suggested.
>
> > Done.
>
> I don't think this fix is either appropriate or adequate.
Agreed (and commented offlist. Which probably was a mistake).
> Or maybe we should reconsider whether
> exec_parse_message should allow the case at all. It's not unreasonable
> that Parse should require exactly one SQL statement, not just "at most
> one".
I think this is the best bet. There really doesn't seem much
justification for the current "at most one" definition. At least not one
that I could find or think of. The likelihood of leaving some places
unfixed or new breakages creeping in seems non-nil; it's not what one
would immediately expect.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | chenchuanling | 2014-09-07 01:05:08 | BUG #11365: denied apache cgi connect |
Previous Message | Tom Lane | 2014-09-06 20:25:28 | Re: BUG #11335: an invalid prepare statement causes crash at log_statement = 'mod' or 'ddl'. |