[PATCH] parser: optionally warn about missing AS for column and table aliases

From: Oskari Saarenmaa <os(at)ohmu(dot)fi>
To: pgsql-hackers(at)postgresql(dot)org
Subject: [PATCH] parser: optionally warn about missing AS for column and table aliases
Date: 2014-09-05 20:38:11
Message-ID: 20140905203810.GG10465@saarenmaa.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote the attached patch to optionally emit warnings when column or table
aliases are used without the AS keyword after errors caused by typos in
statements turning unintended things into aliases came up twice this week.
First in a discussion with a colleague who was surprised by a 1 row result
for the query 'SELECT COUNT(*) files' and again in the "pl/pgsql 2" thread
as plpgsql currently doesn't throw an error if there are more result columns
than output columns (SELECT a b INTO f1, f2).

The patch is still missing documentation and it needs another patch to
modify all the statements in psql & co to use AS so you can use things like
\d and tab-completion without triggering the warnings. I can implement
those changes if others think this patch makes sense.

/ Oskari

Attachment Content-Type Size
0001-parser-optionally-warn-about-missing-AS-for-column-a.patch text/plain 10.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marko Tiikkaja 2014-09-05 20:45:34 Re: [PATCH] parser: optionally warn about missing AS for column and table aliases
Previous Message Merlin Moncure 2014-09-05 20:07:13 Re: Allowing implicit 'text' -> xml|json|jsonb (was: PL/pgSQL 2)