Re: Make LWLockAcquireCommon() inline?

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: pgsql-hackers(at)postgresql(dot)org, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Subject: Re: Make LWLockAcquireCommon() inline?
Date: 2014-09-01 09:58:24
Message-ID: 20140901095823.GC7400@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2014-08-30 14:22:40 +0200, Andres Freund wrote:
> Hi,
>
> when profiling optimized builds (linux, gcc 4.9) it's currently
> LWLockAcquireCommon() showing up, not it's callers. Instruction level
> profiles show that the tests for valptr show up in profiles to some
> extent. Since most callers don't need the valptr logic it seems prudent
> to mark the function inline which will then eliminate the superflous
> branches.
>
> Arguments against?

Done.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Marko Tiikkaja 2014-09-01 10:00:48 Re: PL/pgSQL 2
Previous Message Hannu Krosing 2014-09-01 09:53:45 Re: PL/pgSQL 2