From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Fujii Masao <fujii(at)postgresql(dot)org> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Allow units to be specified in relation option setting value. |
Date: | 2014-08-28 14:30:57 |
Message-ID: | 20140828143057.GF25984@awork2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 2014-08-28 14:11:33 +0200, Andres Freund wrote:
> Hi,
>
> On 2014-08-28 07:15:35 +0000, Fujii Masao wrote:
> > Allow units to be specified in relation option setting value.
> >
> > This introduces an infrastructure which allows us to specify the units
> > like ms (milliseconds) in integer relation option, like GUC parameter.
> > Currently only autovacuum_vacuum_cost_delay reloption can accept
> > the units.
>
> This apparently broke pg_upgrade. I've not checked what's up there.
>
> See
> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prairiedog&dt=2014-08-28%2007%3A16%3A04
> and many others.
The specific error is an unquoted 80ms in WITH
(autovacuum_vacuum_cost_delay=80ms);
Independent of that being fixable with some quoting or such, I'm a bit
doubtful about unconditionally adding the ms here. Won't that make it
unnecessarily hard to get 9.5 dumps into <9.5? I know that we don't make
any promises, but it mostly works nonetheless. And this doesn't seem
worth the breakage.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2014-08-28 16:22:28 | Re: pgsql: Allow units to be specified in relation option setting value. |
Previous Message | Tom Lane | 2014-08-28 14:14:53 | Re: [COMMITTERS] pgsql: Allow units to be specified in relation option setting value. |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2014-08-28 14:34:16 | Re: re-reading SSL certificates during server reload |
Previous Message | Tom Lane | 2014-08-28 14:30:30 | Re: re-reading SSL certificates during server reload |