| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Merlin Moncure <mmoncure(at)gmail(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Atri Sharma <atri(dot)jiit(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP Patch for GROUPING SETS phase 1 |
| Date: | 2014-08-22 12:54:27 |
| Message-ID: | 20140822125427.GX16422@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
* Andrew Gierth (andrew(at)tao11(dot)riddles(dot)org(dot)uk) wrote:
> Having now spent some more time looking, I believe there is a solution
> which makes it unreserved which does not require any significant pain
> in the code. I'm not entirely convinced that this is the right
> approach in the long term, but it might allow for a more planned
> transition.
>
> The absolute minimum seems to be:
>
> GROUPING as a col_name_keyword (since GROUPING(x,y,...) in the select
> list as a <grouping operation> looks like a function call for any
> argument types)
>
> CUBE, ROLLUP, SETS as unreserved_keyword
This means
GROUP BY cube(x,y)
GROUP BY (cube(x,y))
GROUP BY cube(x)
all end up with different meanings though, right?
I'm not sure that's really a better situation.
Thanks,
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2014-08-22 13:44:58 | Re: Proposal to add a QNX 6.5 port to PostgreSQL |
| Previous Message | Jeevan Chalke | 2014-08-22 11:55:15 | Re: add line number as prompt option to psql |