Re: Specifying the unit in storage parameter

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Specifying the unit in storage parameter
Date: 2014-08-08 05:12:17
Message-ID: 20140808051217.GF7101@eldon.alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fujii Masao wrote:
> On Fri, Aug 8, 2014 at 12:56 PM, Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:

> > Hm, what's with the parse_int signature change and the hintmsg thing?
> > Is it just me or the patch is incomplete?
>
> Sorry, probably I failed to see your point. You mean that the signature
> of parse_int needs to be changed so that it includes the hintmsg as the
> argument? If yes, there is no problem. Both signature and function body
> of parse_int has already included the hingmsg as the argument so far.
> Am I missing something?

I just mean that the parse_int function body is not touched by your
patch, unless I am failing to see something.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2014-08-08 05:12:20 Re: Hokey wrong versions of libpq in apt.postgresql.org
Previous Message Fujii Masao 2014-08-08 04:47:04 Re: Specifying the unit in storage parameter