| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: -DDISABLE_ENABLE_ASSERT |
| Date: | 2014-06-19 22:48:17 |
| Message-ID: | 20140619224817.GE16260@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-06-19 19:31:28 +0200, Andres Freund wrote:
> On 2014-05-23 10:01:37 -0400, Tom Lane wrote:
> > Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > > The next question is whether to wait till after the branching with this?
> >
> > +1 for waiting (it's only a couple weeks anyway). This isn't a
> > user-facing feature in any way, so I feel no urgency to ship it in 9.4.
>
> Here's my patch for this that I plan to apply later.
Hm, that missed a couple things. Updated patch attached. Besides adding
the missed documentation adjustments this also removes the -A
commandline/startup packet parameter since it doesn't serve a purpose
anymore.
Does anyone think we should rather keep -A and have it not to anything?
It seems fairly unlikely, but not impossible, that someone had the
great idea to add -A off in their connection options.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Don-t-allow-to-disable-backend-assertions-via-the-de.patch | text/x-patch | 18.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-06-19 23:17:09 | Re: -DDISABLE_ENABLE_ASSERT |
| Previous Message | MauMau | 2014-06-19 22:38:06 | Re: [bug fix] Memory leak in dblink |