From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: crash with assertions and WAL_DEBUG |
Date: | 2014-06-14 21:01:50 |
Message-ID: | 20140614210150.GI6763@awork2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2014-06-14 16:57:33 -0400, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > I noticed that HEAD crashes at startup with assertions disabled and
> > WAL_DEBUG turned on:
>
> I'm beginning to think we're going to have to give up on that
> no-pallocs-in-critical-sections Assert. It was useful to catch
> unnecessarily-dangerous allocations in mainline cases, but getting rid
> of every last corner-case palloc is looking to be, if not impossible,
> at least a lot more trouble than it is worth.
I think we at least need to remove it from 9.4. We shouldn't release
with an assertion that still regularly triggers in more or less
'harmless' situations.
I think it might be worthwile to keep it in master to help maintain the
rule against allocations in critical sections. And perhaps as a reminder
that e.g. the checkpointer is doing bad things...
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2014-06-14 21:11:17 | Re: WAL format and API changes (9.5) |
Previous Message | Andres Freund | 2014-06-14 20:57:40 | Re: crash with assertions and WAL_DEBUG |