Re: pg_xlogdump --stats

From: Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com>
To: furuyao(at)pm(dot)nttdata(dot)co(dot)jp
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_xlogdump --stats
Date: 2014-06-13 07:31:10
Message-ID: 20140613073110.GQ5162@toroid.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At 2014-06-10 18:04:13 +0900, furuyao(at)pm(dot)nttdata(dot)co(dot)jp wrote:
>
> The function works fine. It is a good to the learning of PostgreSQL.

Thanks for having a look.

> pg_xlogdump.c: In function ‘XLogDumpStatsRow’:
> pg_xlogdump.c:851: warning: format ‘%20llu’ expects type ‘long long unsigned int’, but argument 3 has type ‘uint64’

I've changed this to use %zu at Álvaro's suggestion. I'll post an
updated patch after I've finished some (unrelated) refactoring.

-- Abhijit

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2014-06-13 07:31:59 Re: Few observations in replication slots related code
Previous Message Quan Zongliang 2014-06-13 07:20:18 PL/pgSQL support to define multi variables once