From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Re: popen and pclose redefinitions causing many warning in Windows build |
Date: | 2014-06-06 17:18:24 |
Message-ID: | 20140606171824.GV5146@eldon.alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Bruce Momjian wrote:
> On Wed, May 28, 2014 at 12:29:28PM -0400, Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > I think this is caused because the variable is not defined as SOCKET.
> > > The attached patch fixes this. This should prevent the warning.
> >
> > Surely that's just going to move the errors somewhere else. The call
> > site still expects the argument to be int[].
>
> Ah, yes, you are right. This is a similar problem I had with libpq
> where PQsocket() had to return an int.
>
> Attached is an updated patch which follows my previous coding of
> checking for PGINVALID_SOCKET, and if not equal, assigns the value to an
> integer handle. I would also like to rename variable 's' to
> 'listen_sock', but that is not in the patch, for clarity reasons.
>
> Should this be held for 9.5? I think it is only warning removal. On
> the other hand, portability is what we do during beta testing.
I think this should go in 9.4, but as you say it's only warning removal
so there is probably little point in patching further back (this code
dates back to 9.3.)
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2014-06-06 18:08:26 | Re: BUG #8673: Could not open file "pg_multixact/members/xxxx" on slave during hot_standby |
Previous Message | Andres Freund | 2014-06-06 17:16:56 | Re: BUG #8673: Could not open file "pg_multixact/members/xxxx" on slave during hot_standby |