| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: Logical slots not mentioned in CREATE_REPLICATION_SLOT for replication protocol docs |
| Date: | 2014-05-31 14:02:55 |
| Message-ID: | 20140531140255.GB4286@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-05-30 08:12:35 +0900, Michael Paquier wrote:
> On Fri, May 30, 2014 at 5:31 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > Thanks, this looks good. But shouldn't the bit about output plugin
> > options mention say something like:
> >
> > ( option_name option_argument [, ...] )
> >
> > ...instead of just:
> >
> > ( option [, ...] )
> > ?
> Yes, true. Here is an updated patch.
I've pushed the patch with some additional changes. Hope they make sense
to you.
I wonder whether START_REPLICATION ... LOGICAL should be folded into
... PHYSICAL since they have most things in common. But it'd be a
awfully complicated description.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-05-31 14:09:36 | Re: FOR [SHARE|UPDATE] NOWAIT may still block in EvalPlanQualFetch |
| Previous Message | reiner peterke | 2014-05-31 08:01:29 | Re: unable to build postgres-9.4 in os x 10.9 with python |