Re: [HACKERS] Re: pgsql: Fix bogus %name-prefix option syntax in all our Bison files.

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, pgsql-committers(at)postgresql(dot)org
Subject: Re: [HACKERS] Re: pgsql: Fix bogus %name-prefix option syntax in all our Bison files.
Date: 2014-05-29 13:25:35
Message-ID: 20140529132535.GL27914@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2014-05-29 08:33:05 -0400, Peter Eisentraut wrote:
> On 5/28/14, 7:02 PM, Andres Freund wrote:
> > That's a good idea. What i've been thinking about is to add
> > -Wno-deprecated to the bison rule in the interim. Maybe after a
> > configure test for the option. All deprecation warnings so far seem to
> > be pretty unhelpful.
>
> Here is a patch.

FWIW, I vote for applying something like it. It seems better to collect
the -Wno-deprecated in one place (i.e. configure) instead of having it
in every developer's Makefile.custom. The latter will be harder to get
rid of.
I'd add a comment about why it's been added though. I won't remember why
at least...

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2014-05-29 13:47:21 Re: Re: [COMMITTERS] pgsql: Fix bogus %name-prefix option syntax in all our Bison files.
Previous Message Peter Eisentraut 2014-05-29 12:33:05 Re: [HACKERS] Re: pgsql: Fix bogus %name-prefix option syntax in all our Bison files.

Browse pgsql-hackers by date

  From Date Subject
Next Message Claudio Freire 2014-05-29 13:28:27 Re: Extended Prefetching using Asynchronous IO - proposal and patch
Previous Message John Lumby 2014-05-29 13:18:25 Re: Extended Prefetching using Asynchronous IO - proposal and patch