Re: [COMMITTERS] pgsql: Fix bogus %name-prefix option syntax in all our Bison files.

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-committers(at)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: [COMMITTERS] pgsql: Fix bogus %name-prefix option syntax in all our Bison files.
Date: 2014-05-28 23:20:04
Message-ID: 20140528232004.GH27914@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2014-05-28 19:12:44 -0400, Tom Lane wrote:
> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > On 2014-05-28 18:52:22 -0400, Tom Lane wrote:
> >> and IMO we should also lobby the Bison people to not emit the
> >> deprecation warnings yet.
>
> > That's a good idea. What i've been thinking about is to add
> > -Wno-deprecated to the bison rule in the interim. Maybe after a
> > configure test for the option. All deprecation warnings so far seem to
> > be pretty unhelpful.
>
> Meh. If we just hide them permanently, we're likely to be blindsided
> somewhere down the road when they turn a deprecation into an error.

I think some bleeding edge buildfarm animal will warn us soon
enough. It's not as if we're able to do much about the deprecations as
is without breaking with older releases.

> What I was wondering about was if we could modify the .y files when
> building with a pre-2.4 bison. It'd be easy enough to fix this with
> sed, say.

.oO(m4). Should be doable and might actually be interesting for a couple
of other things.

I think I'll just stick a BISONFLAGS=+ -Wno-deprecated in my
Makefile.custom for now. I.e. I am not volunteering.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2014-05-28 23:30:38 pgsql: Revert "Fix bogus %name-prefix option syntax in all our Bison fi
Previous Message Tom Lane 2014-05-28 23:12:44 Re: pgsql: Fix bogus %name-prefix option syntax in all our Bison files.

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2014-05-29 00:07:58 Re: Compression of full-page-writes
Previous Message Tom Lane 2014-05-28 23:12:44 Re: pgsql: Fix bogus %name-prefix option syntax in all our Bison files.