| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Allowing line-continuation in pgbench custom scripts |
| Date: | 2014-05-26 17:53:02 |
| Message-ID: | 20140526175302.GB11572@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-05-26 11:44:31 -0400, Tom Lane wrote:
> Amit Langote <amitlangote09(at)gmail(dot)com> writes:
> > In a custom pgbench script, it seems convenient to be able to split a
> > really long query to span multiple lines using an escape character
> > (bash-style). Attached adds that capability to read_line_from_file()
> > in pgbench.c
>
> This seems pretty likely to break existing scripts that happen to contain
> backslashes. Is it really worth the compatibility risk?
Weaknesses in the implementation aside, I don't think pgbench has to be
hold up to the same level of compatibility as many of our other
tools. It's just a benchmark tool after all.
I've more than once wished for the capability.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-05-26 18:04:21 | Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD |
| Previous Message | Matteo Beccati | 2014-05-26 17:51:25 | Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD |