Re: wrapping in extended mode doesn't work well with default pager

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Sergey Muraviov <sergey(dot)k(dot)muraviov(at)gmail(dot)com>
Cc: Greg Stark <stark(at)mit(dot)edu>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Emre Hasegeli <emre(at)hasegeli(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: wrapping in extended mode doesn't work well with default pager
Date: 2014-05-23 14:10:23
Message-ID: 20140523141023.GX7857@eldon.alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Sergey Muraviov wrote:
> I found some new bugs and fix them.
> And I had to make many changes.

This version fixes some bugs I had noticed in expanded mode too. For instance,
the original looked like this (five lines plus header):

-[ RECORD 49 ]-----+-------------------------------------------------------------------------
pg_identify_object | (rule,,,"""_RETURN"" on pg_catalog.pg_available_extension_versions")

pg_identify_object | (view,pg_catalog,pg_available_extension_versions,pg_catalog.pg_availabl
e.
|._extension_versions)

whereas it's correctly only three lines plus header with this patch
applied. I can't tell whether this patch is minimal enough.

Having a more comprehensive test case is good, of course, though I
didn't check the expected file. Note that some things cannot be tested
correctly in this way, namely column count that actually match the
terminal -- to wit: I had to add line breaks manually to the above paste
so that it would look like what it does in my terminal. If I just paste
it, it looks correct, but then my email terminal is wider than the one I
ran psql in. I would presume that failure to account for this is what
caused (some of?) the bugs being fixed now ...

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabrízio de Royes Mello 2014-05-23 14:13:50 Re: postgres_fdw and connection management
Previous Message Bruce Momjian 2014-05-23 14:09:35 Re: pg_upgrade fails: Mismatch of relation OID in database 8.4 -> 9.3