| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: -DDISABLE_ENABLE_ASSERT |
| Date: | 2014-05-22 21:00:13 |
| Message-ID: | 20140522210013.GU7857@eldon.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund wrote:
> On 2014-05-22 16:37:35 -0400, Tom Lane wrote:
> > We could do that ... but I wonder if we shouldn't remove assert_enabled
> > altogether. What's the use case for turning it off? Not matching the
> > speed of a non-cassert build, because for instance MEMORY_CONTEXT_CHECKING
> > doesn't get turned off.
>
> I've used it once or twice to avoid having to recompile postgres when I
> wanted things not to be *that* slow (AtEOXactBuffers() I am looking at
> you). But I wouldn't be very sad if it'd go.
>
> Anybody against that?
I have used it too (for a different reason IIRC), but like you I
wouldn't have a problem if it weren't there.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomonari Katsumata | 2014-05-23 01:11:37 | Re: 9.4 release notes |
| Previous Message | Andres Freund | 2014-05-22 20:47:37 | Re: -DDISABLE_ENABLE_ASSERT |