| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Steve Singer <steve(at)ssinger(dot)info> |
| Cc: | PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: CREATE REPLICATION SLOT fails on a timeout |
| Date: | 2014-05-16 23:34:25 |
| Message-ID: | 20140516233425.GD9100@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-05-16 17:02:33 -0400, Steve Singer wrote:
> >I don't think that's going to cut it though. The creation can take
> >longer than whatever wal_sender_timeout is set to (when there's lots of
> >longrunning transactions). I think checking whether last_reply_timestamp
> >= 0 during timeout checking is more robust.
> That makes sense.
> A patch that does that is attached.
I've attached a heavily revised version of that patch. Didn't touch all
the necessary places...
Survives creation of logical replication slots under 'intensive
pressure', with a wal_sender_timeout=10ms.
Thanks for the bugreport!
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Don-t-pay-heed-to-wal_sender_timeout-while-creating-.patch | text/x-patch | 3.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-05-17 00:32:00 | Re: Scaling shared buffer eviction |
| Previous Message | Andres Freund | 2014-05-16 23:00:35 | Re: %d in log_line_prefix doesn't work for bg/autovacuum workers |