| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: Logical replication woes |
| Date: | 2014-05-15 20:58:20 |
| Message-ID: | 20140515205820.GE16014@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-05-15 22:30:53 +0300, Heikki Linnakangas wrote:
> >Attached patch fixes things, but I want to add some regression tests
> >before commit.
>
> Looks good to me.
Attached are two patches. One for the unitialized dbId/tsId issue; one
for the decoding bug. The former should be backpatched.
Should you wonder about the slight reordering of the assignments in
RecordTransactionCommitPrepared() - I've made it more similar to RecordTransactionCommit()
to make it easier to see they are equivalent.
Thanks for the testing!
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Initialize-all-members-of-xl_xact_commit-during-prep.patch | text/x-patch | 1.8 KB |
| 0002-Fix-typo-induced-bug-in-decoding-of-prepared-transac.patch | text/x-patch | 8.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-05-15 21:09:14 | pg_recvlogical tests |
| Previous Message | Andrew Dunstan | 2014-05-15 20:56:38 | Re: buildfarm animals and 'snapshot too old' |