Re: [PATCH] Writing changes of decoding plugin in the memory context where data is kept?

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Writing changes of decoding plugin in the memory context where data is kept?
Date: 2014-05-15 00:18:38
Message-ID: 20140515001838.GK23943@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2014-05-15 09:11:15 +0900, Michael Paquier wrote:
> When working on a decoder plugin, I have been pointed that it is
> incorrect to write changes in an output plugin while not being in the
> memory context where changes are written.

That was a misunderstanding. It's perfectly alright to do so. The 'bug'
you have is that you sometimes wrote empty messages. Which
pg_recvlogical doesn't accept. There's little reason to allow doing so,
but for consistency we could probably ok to allow it.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2014-05-15 00:19:36 Re: buildfarm / handling (undefined) locales
Previous Message Tom Lane 2014-05-15 00:13:06 Re: Cache invalidation bug in RelationGetIndexAttrBitmap()