| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: btree_gist valgrind warnings about uninitialized memory |
| Date: | 2014-05-14 12:17:21 |
| Message-ID: | 20140514121721.GC23943@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-05-14 14:55:38 +0300, Heikki Linnakangas wrote:
> On 05/13/2014 05:13 PM, Andres Freund wrote:
> >That leaves the spgist thing and some infrastructure till we can setup a
> >valgrind animal... From what we've caught with it so far that seems
> >rather worthwile.
> >What's your plans with your spgist fix? Commit it once 9.5 is branched?
>
> Good question. I don't know. I would still like to commit it to 9.4. It
> doesn't require catalog changes, but it's an incompatible change in the WAL
> record format. If we commit it to 9.4, it means that you cannot replicate
> between 9.4beta1 and 9.4beta2. I think that's OK, but how do others feel
> about that?
I personally think that's not too bad.
Alternatively we could come up with a second way that's not breaking the
WAL format. I'd feel better if we had a back patchable fix...
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2014-05-14 13:08:08 | Re: Sending out a request for more buildfarm animals? |
| Previous Message | Heikki Linnakangas | 2014-05-14 12:15:38 | Re: popen and pclose redefinitions causing many warning in Windows build |