Re: pgsql: Revive line type

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Revive line type
Date: 2014-05-05 15:58:35
Message-ID: 20140505155835.GD27783@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi Peter,

On 2013-10-10 02:43:20 +0000, Peter Eisentraut wrote:
> Revive line type
>
> Change the input/output format to {A,B,C}, to match the internal
> representation.
>
> Complete the implementations of line_in, line_out, line_recv, line_send.
> Remove comments and error messages about the line type not being
> implemented. Add regression tests for existing line operators and
> functions.
>
> Reviewed-by: rui hua <365507506hua(at)gmail(dot)com>
> Reviewed-by: Álvaro Herrera <alvherre(at)2ndquadrant(dot)com>
> Reviewed-by: Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>

That commit missed to update pg_type.h to the changed length of the line
type. Patch attached.

That oversight leads to accesses beyond the length of the tuple in
routines like datumCopy().

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
fix-line-type-len.patch text/x-patch 884 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2014-05-05 16:38:15 pgsql: Add SGML markup tags to 9.4 release notes
Previous Message Tom Lane 2014-05-05 15:26:51 pgsql: Fix case of pg_dump -Fc to an unseekable file (such as a pipe).

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2014-05-05 16:06:17 Re: 9.4 release notes
Previous Message Stephen Frost 2014-05-05 15:40:17 Re: Cluster name in ps output