| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Ants Aasma <ants(at)cybertec(dot)at> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com> |
| Subject: | Re: Missing pfree in logical_heap_rewrite_flush_mappings() |
| Date: | 2014-04-23 02:25:19 |
| Message-ID: | 20140423022519.GA12697@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 22, 2014 at 06:05:53PM -0400, Bruce Momjian wrote:
> On Wed, Mar 26, 2014 at 06:29:38PM +0200, Ants Aasma wrote:
> > It seems to me that when flushing logical mappings to disk, each
> > mapping file leaks the buffer used to pass the mappings to XLogInsert.
> > Also, it seems consistent to allocate that buffer in the RewriteState
> > memory context. Patch attached.
>
> Patch applied.
I had to revert this patch. It causes a failure in the
/contrib/test_decoding regression test.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-04-23 02:37:37 | Re: Missing pfree in logical_heap_rewrite_flush_mappings() |
| Previous Message | Sergey Burladyan | 2014-04-23 01:33:26 | pg_upgrade and epoch |