| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: shouldn't we log permission errors when accessing the configured trigger file? |
| Date: | 2014-04-17 15:56:15 |
| Message-ID: | 20140417155615.GG7443@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 16, 2014 at 06:55:14PM -0400, Bruce Momjian wrote:
> > Seems reasonable. It could lead to quite a bit of log spam, I
> > suppose, but the way things are now could be pretty mystifying if
> > you've located your trigger file somewhere outside $PGDATA, and a
> > parent directory is lacking permissions.
> >
> >
> > +1. Since it actually indicates something that's quite broken (since with that
> > you can never make the trigger work until you fix it), the log spam seems like
> > it would be appropriate. (Logspam is never nice, but a single log line is also
> > very easy to miss - this should log enough that you wouldn't)
>
> I have developed the attached patch to address this issue.
Patch applied.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2014-04-17 16:21:40 | Re: Clock sweep not caching enough B-Tree leaf pages? |
| Previous Message | Bruce Momjian | 2014-04-17 15:46:39 | Re: Verbose output of pg_dump not show schema name |