| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Joel Jacobson <joel(at)trustly(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [BUG FIX] Compare returned value by socket() against PGINVALID_SOCKET instead of < 0 |
| Date: | 2014-04-16 23:48:06 |
| Message-ID: | 20140416234806.GT7443@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 16, 2014 at 11:22:28AM -0400, Bruce Momjian wrote:
> On Fri, Apr 11, 2014 at 08:28:55AM -0400, Bruce Momjian wrote:
> > Once this is applied I will work on changing the libpq socket type to
> > use portable pgsocket, but I am not planning to backpatch that unless we
> > find a bug.
>
> Attached is a follow up patch which stores socket values in libpq as
> pgsocket, rather than int, and maps it to -1 only for the PQsocket()
> external return value. In the interest of time, I will apply this later
> today, and only to head as it does not fix a bug.
>
> This is the last open item I was working on.
Applied. FYI, Joel Jacobson was the initial author of this thread of
patches; report by PVS-Studio.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2014-04-16 23:54:07 | Re: client encoding that psql command sets |
| Previous Message | Bruce Momjian | 2014-04-16 23:38:53 | Re: Minor performance improvement in transition to external sort |