From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Marco Atzeri <marco(dot)atzeri(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: test failure on latest source |
Date: | 2014-04-16 15:14:27 |
Message-ID: | 20140416151427.GN5822@eldon.alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Marco Atzeri wrote:
> On 13/04/2014 18:09, Tom Lane wrote:
> >Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> >>On 2014-04-12 16:35:48 -0400, Tom Lane wrote:
> >>>In principle, that commit shouldn't have affected behavior for pg_hba
> >>>entries with numeric address fields ...
> >
> >>Hm. getaddrinfo.c has this bit:
> >> /* Unsupported flags. */
> >> if (flags & NI_NAMEREQD)
> >> return EAI_AGAIN;
> >
> >Yeah, and that flag is only ever specified when attempting to do reverse
> >lookup on a client address to see if it matches a non-numeric pg_hba
> >entry.
I don't know if this is relevant, but perhaps we're defining the
constants in a way that conflicts with the values defined by cygwin. A
very quick search finds a 2007 patch for Mutt[1] that seems to have
NI_NAMEREQD defined as 8 somewhere, while 4 is NI_NOFQDN. But we have
this in getaddrinfo.h:
#ifndef NI_NAMEREQD
#define NI_NAMEREQD 4
#endif
So maybe we're doing something wrong. Indeed, my system has in
/usr/include/netdb.h
# define NI_NAMEREQD 8 /* Don't return numeric addresses. */
You'd do well to research this more, I think.
[1] http://marc.info/?l=mutt-dev&m=117752314512877&w=2
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2014-04-16 15:22:28 | Re: [BUG FIX] Compare returned value by socket() against PGINVALID_SOCKET instead of < 0 |
Previous Message | Andres Freund | 2014-04-16 15:09:47 | Re: Clock sweep not caching enough B-Tree leaf pages? |