| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Joel Jacobson <joel(at)trustly(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [BUG FIX] Compare returned value by socket() against PGINVALID_SOCKET instead of < 0 |
| Date: | 2014-04-16 13:48:56 |
| Message-ID: | 20140416134856.GA7443@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 16, 2014 at 10:34:55AM -0300, Alvaro Herrera wrote:
> Bruce Momjian wrote:
> >
> > Yes, I saw that yesterday and fixed it. I also did a dry run of
> > backpatching and only 8.4 had conflicts, so I think we are good there.
> > (This is like the readdir() fix all over again.)
> >
> > Once this is applied I will work on changing the libpq socket type to
> > use portable pgsocket, but I am not planning to backpatch that unless we
> > find a bug.
>
> Are we done with this patch?
I am about to patch it now. I was going to do it yesterday but was
concerned I wouldn't be online long enough to catch any buildfarm
failure.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marco Atzeri | 2014-04-16 14:12:11 | Re: test failure on latest source |
| Previous Message | Andres Freund | 2014-04-16 13:35:33 | Re: Clock sweep not caching enough B-Tree leaf pages? |