| From: | Marko Kreen <markokr(at)gmail(dot)com> |
|---|---|
| To: | Jan Wieck <jan(at)wi3ck(dot)info> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Problem with txid_snapshot_in/out() functionality |
| Date: | 2014-04-14 08:55:33 |
| Message-ID: | 20140414085533.GA20735@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Apr 13, 2014 at 05:46:20PM -0400, Jan Wieck wrote:
> On 04/13/14 14:22, Jan Wieck wrote:
> >On 04/13/14 08:27, Marko Kreen wrote:
> >>I think you need to do SET_VARSIZE also here. Alternative is to
> >>move SET_VARSIZE after sort_snapshot().
> >>
> >>And it seems the drop-double-txid logic should be added also to
> >>txid_snapshot_recv(). It seems weird to have it behave differently
> >>from txid_snapshot_in().
> >>
> >
> >Thanks,
> >
> >yes on both issues. Will create another patch.
>
> New patch attached.
>
> New github commit is https://github.com/wieck/postgres/commit/b8fd0d2eb78791e5171e34aecd233fd06218890d
Looks OK to me.
--
marko
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Olivier Lalonde | 2014-04-14 09:00:01 | Re: Adding unsigned 256 bit integers |
| Previous Message | Albe Laurenz | 2014-04-14 08:19:51 | Re: CLOB & BLOB limitations in PostgreSQL |