Re: BUG #8695: Reloading dump fails at COMMENT ON EXTENSION plpgsql

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: chris(at)chrullrich(dot)net, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #8695: Reloading dump fails at COMMENT ON EXTENSION plpgsql
Date: 2014-04-10 12:11:08
Message-ID: 20140410121108.GA6917@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Wed, Apr 9, 2014 at 11:13:57PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > That's what I thought too, but I see a schema file in pg_extensions:
>
> Read the manual.
>
> > Should we hard-code a pg_catalog plpgsql to be skipped in pg_dump?
>
> No, I don't think so.
>
> The real issue here is that we don't have a notion of a "built-in
> extension". I think this was specifically debated back when we
> extension-ified plpgsql, though I don't recall details of why
> we ended up not doing that. Maybe the idea was that you could
> drop and then re-add plpgsql? Anyway, I think this is not such
> a simple issue and a one-line hack in pg_dump is not likely to
> improve matters.

OK, I added a TODO:

Prevent PL/pgSQL comment from throwing an error in a
non-superuser restore

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Greg Stark 2014-04-10 18:45:53 Re: log_checkpoints, microseconds
Previous Message John R Pierce 2014-04-10 06:03:05 Re: log_checkpoints, microseconds