| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Greg Stark <stark(at)mit(dot)edu> |
| Cc: | Emre Hasegeli <emre(at)hasegeli(dot)com>, Sergey Muraviov <sergey(dot)k(dot)muraviov(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Problem with displaying "wide" tables in psql |
| Date: | 2014-04-08 16:19:05 |
| Message-ID: | 20140408161905.GV4161@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-04-08 12:15:47 -0400, Greg Stark wrote:
> With no doc changes and no regression tests I was halfway inclined to
> just reject it out of hand. To be fair there were no regression tests
> for wrapped output prior to the patch but still I would have wanted to
> see them added. We often pare down regression tests when committing
> patches but it's easier to pare them down than write new ones and it
> helps show the author's intention.
I don't think this is easily testable that way - doesn't it rely on
determining the width of the terminal? Which you won't have when started
from pg_regress?
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-04-08 16:23:34 | Re: Minor improvements in alter_table.sgml |
| Previous Message | Greg Stark | 2014-04-08 16:15:47 | Re: Problem with displaying "wide" tables in psql |