From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Something flaky in the "relfilenode mapping" infrastructure |
Date: | 2014-03-28 20:52:00 |
Message-ID: | 20140328205200.GF26319@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2014-03-28 16:45:28 -0400, Tom Lane wrote:
> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > On 2014-03-28 16:41:15 -0400, Tom Lane wrote:
> >> Any objection to separating out the have_mappings bit? It wasn't terribly
> >> appropriate before, but it seems really out of place in this formulation.
>
> > The patch I sent removed the have_mapping thing entirely? Do you mean it
> > should be there, but as a separate query?
>
> Oh, so it did. Well, do you think we need a query checking that?
> I hadn't questioned the need to do so, but if you feel it's unnecessary
> I'm certainly willing to pull it.
I don't think it's necessary. As far as I understand LATERAL, a join to
a function returning NULL will still return the row. So, the test now
would only test whether there are rows in pg_class which seems a bit
pointless.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2014-03-28 20:55:49 | Re: Something flaky in the "relfilenode mapping" infrastructure |
Previous Message | Tom Lane | 2014-03-28 20:45:28 | Re: Something flaky in the "relfilenode mapping" infrastructure |