| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Allow opclasses to provide tri-valued GIN consistent functions. |
| Date: | 2014-03-21 21:26:26 |
| Message-ID: | 20140321212626.GB17111@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Hi,
On 2014-03-12 15:52:58 +0000, Heikki Linnakangas wrote:
> Allow opclasses to provide tri-valued GIN consistent functions.
clang warns me about a mistake here:
In file included from /home/andres/src/postgresql/src/backend/access/gin/ginxlog.c:16:
In file included from /home/andres/src/postgresql/src/include/access/gin_private.h:14:
/home/andres/src/postgresql/src/include/access/gin.h:57:3: warning: no previous extern declaration for
non-static variable 'GinLogicValueEnum'
[-Wmissing-variable-declarations]
} GinLogicValueEnum;
I think the GinLogicValueEnum is supposed to be an enum's name, not a
variable name, right?
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| typo-gin-logic-value.patch | text/x-patch | 535 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-03-21 21:37:35 | Re: pgsql: Allow opclasses to provide tri-valued GIN consistent functions. |
| Previous Message | Bruce Momjian | 2014-03-21 17:47:43 | pgsql: Remove MinGW readdir/errno bug workaround fixed on 2003-10-10 |