| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kevin Grittner <kgrittn(at)ymail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_archivecleanup bug |
| Date: | 2014-03-18 18:18:50 |
| Message-ID: | 20140318181850.GD4776@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 18, 2014 at 06:11:30PM +0000, Simon Riggs wrote:
> On 18 March 2014 18:01, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > On Tue, Mar 18, 2014 at 04:17:53PM +0000, Simon Riggs wrote:
> >> > While I am not a fan of backpatching, the fact we are ignoring errors in
> >> > some critical cases seems the non-cosmetic parts should be backpatched.
> >>
> >> pg_resetxlog was not an offender here; its coding was sound.
> >>
> >> We shouldn't be discussing backpatching a patch that contains changes
> >> to coding style.
> >
> > I was going to remove the coding style changes to pg_resetxlog from the
> > backpatched portion.
>
> Why make style changes at all? A patch with no style changes would
> mean backpatch and HEAD versions would be the same.
The old style had errno set in two places in the loop, while the new
style has it set in only one place.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Atri Sharma | 2014-03-18 18:21:47 | Re: Risk Estimation WAS: Planner hints in Postgresql |
| Previous Message | Josh Berkus | 2014-03-18 18:13:22 | Re: Risk Estimation WAS: Planner hints in Postgresql |