Re: pg_archivecleanup bug

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kevin Grittner <kgrittn(at)ymail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_archivecleanup bug
Date: 2014-03-18 18:01:19
Message-ID: 20140318180119.GC4776@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 18, 2014 at 04:17:53PM +0000, Simon Riggs wrote:
> > While I am not a fan of backpatching, the fact we are ignoring errors in
> > some critical cases seems the non-cosmetic parts should be backpatched.
>
> pg_resetxlog was not an offender here; its coding was sound.
>
> We shouldn't be discussing backpatching a patch that contains changes
> to coding style.

I was going to remove the coding style changes to pg_resetxlog from the
backpatched portion.

> ISTM we should change the code with missing checks to adopt the coding
> style of pg_resetxlog, not the other way around.
>
> I assume you or Kevin have this in hand and you don't want me to apply
> the patch? (Since it was originally my bug)

I know the email subject says pg_archivecleanup but the problem is all
over our code.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2014-03-18 18:11:30 Re: pg_archivecleanup bug
Previous Message Andres Freund 2014-03-18 17:36:31 Re: Portability issues in shm_mq