| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: warning when compiling utils/tqual.h |
| Date: | 2014-03-17 17:00:12 |
| Message-ID: | 20140317170012.GF26328@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-03-17 12:57:15 -0400, Tom Lane wrote:
> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > On 2014-03-17 12:50:37 -0400, Tom Lane wrote:
> >> I guess the real question is why such a prototype is in tqual.h in
> >> the first place. ISTM this should be pushed somewhere specific to
> >> reorderbuffer.c. I'm -1 on having struct HTAB bleed into tqual.h
> >> via either of the methods you suggest.
>
> > It's the only logical decoding specific routine that's called by tqual.c
> > which doesn't need anything else from reorderbuffer. I'd like to avoid
> > more stuff bleeding in there...
>
> Instead, you'd like HTAB to bleed into everything that uses tqual.h?
Meh. a struct forward declaration isn't exactly a significant thing to
expose.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-03-17 17:03:49 | Re: warning when compiling utils/tqual.h |
| Previous Message | Tom Lane | 2014-03-17 16:57:15 | Re: warning when compiling utils/tqual.h |