Re: Replication slots and footguns

On 2014-03-12 13:34:47 -0700, Josh Berkus wrote:
> On 03/12/2014 12:34 PM, Robert Haas wrote:
> >>> Urgh. That error message looks susceptible to improvement. How about:
> >>> >>
> >>> >> replication slot "%s" cannot be dropped because it is currently in use
> >> >
> >> > I think that'd require duplicating some code between acquire and drop,
> >> > but how about "replication slot "%s" is in use by another backend"?
> > Sold.
>
> Wait ... before you go further ... I object to dropping the word
> "active" from the error message. The column is called "active", and
> that's where a DBA should look; that word needs to stay in the error
> message.

"replication slot "%s" is in active in another backend"?

Alternatively we could replace the boolean active by the owner's pid,
but that's a not entirely trivial change...

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services