| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Gurjeet Singh <gurjeet(at)singh(dot)im> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Shave a few instructions from child-process startup sequence |
| Date: | 2014-03-08 03:58:58 |
| Message-ID: | 20140308035858.GH16324@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Dec 1, 2013 at 12:07:21PM -0500, Gurjeet Singh wrote:
> On Wed, Nov 27, 2013 at 9:12 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
>
> This is a performance patch, so it should come with benchmark results
> demonstrating that it accomplishes its intended purpose. I don't see
> any.
>
>
> Yes, this is a performance patch, but as the subject says, it saves a few
> instructions. I don't know how to write a test case that can measure savings of
> skipping a few instructions in a startup sequence that potentially takes
> thousands, or even millions, of instructions.
Are we saying we don't want this patch?
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabrízio de Royes Mello | 2014-03-08 05:28:13 | Re: [PATCH] Store Extension Options |
| Previous Message | Bruce Momjian | 2014-03-08 03:46:56 | Re: pg_upgrade: delete_old_cluster.sh issues |