From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_ctl status with nonexistent data directory |
Date: | 2014-03-07 04:11:08 |
Message-ID: | 20140307041108.GF11419@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Mar 7, 2014 at 09:07:24AM +0530, Amit Kapila wrote:
> One reason could be that as we are already returning special exit code
> for 'status' option of pg_ctl (exit(3)), this seems to be inline with it as this
> also get called during status command.
>
> Also in the link sent by you in another mail, I could see some statement
> which indicates it is more important to return correct codes in case of
> status which sounds a good reason to me.
>
> Link and statement
> http://www.postgresql.org/message-id/51D1E482.5090602@gmx.net
>
> "The "status" case is different, because there the exit code
> can be passed out by the init script directly."
>
> If we just want to handle correct exit codes for "status" option, then
> may be we need to refactor the code a bit to ensure the same.
OK, done with the attached patch Three is returned for status, but one
for other cases.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
Attachment | Content-Type | Size |
---|---|---|
pg_ctl.diff | text/x-diff | 5.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2014-03-07 04:33:13 | Re: jsonb and nested hstore |
Previous Message | Bruce Momjian | 2014-03-07 03:45:16 | Re: pg_ctl status with nonexistent data directory |