Re: pg_ctl status with nonexistent data directory

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_ctl status with nonexistent data directory
Date: 2014-03-06 14:16:24
Message-ID: 20140306141624.GA20070@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 6, 2014 at 09:54:57AM +0530, Amit Kapila wrote:
> > If they haven't passed us a data directory, we don't really know if the
> > server is running or not, so the patch just returns '1'.
>
> But for such cases, isn't the status 4 more appropriate?
> As per above link "4 program or service status is unknown"
>
> status 1 - "1 program is dead and /var/run pid file exists"
> Going by this definition, it seems status 1 means, someone
> has forcefully killed the server and pid file still remains.

Technically, you are right, but I tried a while ago to assign meaningful
values to all the exit locations and the community feedback I got was
that we didn't want that. I don't see how specifying non-existant or
non-cluster directory would somehow be a case that would be special.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2014-03-06 14:33:18 Re: jsonb and nested hstore
Previous Message Oleg Bartunov 2014-03-06 13:16:22 Re: jsonb and nested hstore