| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, peter_e(at)gmx(dot)net, robertmhaas(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: UNION ALL on partitioned tables won't use indices. |
| Date: | 2014-02-28 02:47:09 |
| Message-ID: | 20140228024709.GA3355432@tornado.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 27, 2014 at 05:47:16PM -0500, Tom Lane wrote:
> BTW, isn't the proposed change to the comments for adjust_appendrel_attrs
> just wrong? If it's correct, why doesn't the Assert(!IsA(node, SubLink))
> therein fire? (AFAICS, the existing comment is correct: we don't use
> this function until after expression preprocessing is complete.)
The comment change is accurate; expand_inherited_tables(), which precedes
subplan conversion, now calls adjust_appendrel_attrs(). I neglected to remove
the SubLink assert or test a scenario actually entailing a SubLink in
translated_vars. Thanks for spotting the problem.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2014-02-28 02:53:52 | Re: UNION ALL on partitioned tables won't use indices. |
| Previous Message | Peter Eisentraut | 2014-02-28 02:44:48 | Re: tests for client programs |