| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Greg Stark <stark(at)mit(dot)edu>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Geoghegan <pg(at)heroku(dot)com> |
| Subject: | Re: Another possible corruption bug in 9.3.2 or possibly a known MultiXact problem? |
| Date: | 2014-02-26 22:26:46 |
| Message-ID: | 20140226222646.GE6718@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-02-26 18:18:05 -0300, Alvaro Herrera wrote:
> Andres Freund wrote:
>
> > static void
> > heap_xlog_lock(XLogRecPtr lsn, XLogRecord *record)
> > {
> > ...
> > HeapTupleHeaderClearHotUpdated(htup);
> > HeapTupleHeaderSetXmax(htup, xlrec->locking_xid);
> > HeapTupleHeaderSetCmax(htup, FirstCommandId, false);
> > /* Make sure there is no forward chain link in t_ctid */
> > htup->t_ctid = xlrec->target.tid;
> > ...
> > }
>
> I think the fix is to reset HOT_UPDATED and t_ctid only if the infomask
> says the tuple is LOCKED_ONLY, per the attached patch.
Looks good to me.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-02-26 22:45:41 | Re: jsonb and nested hstore |
| Previous Message | Andres Freund | 2014-02-26 22:22:40 | Re: Another possible corruption bug in 9.3.2 or possibly a known MultiXact problem? |